fix: add attribute merging to logCheckoutOptionEvent#64
Closed
khushi1033 wants to merge 4 commits intodevelopmentfrom
Closed
fix: add attribute merging to logCheckoutOptionEvent#64khushi1033 wants to merge 4 commits intodevelopmentfrom
khushi1033 wants to merge 4 commits intodevelopmentfrom
Conversation
# [1.5.0](v1.4.5...v1.5.0) (2025-05-05) ### Features * Map product position to GA4 item index ([#62](#62)) ([308076c](308076c))
Collaborator
|
For updates, please do not include the dist/ folder. We should probably add that to the gitignore actually, if you wouldn't mind doing that. The dist/ folder is created when we do a release. |
khushi1033
deleted the
fix/SDKE-781-add-attribute-merging-to-logCheckoutOptionEvent
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logCheckoutOptionEvent was missing the event.EventAttributes merging step that all other commerce event handlers perform before forwarding to GA4. This caused add_shipping_info and add_payment_info events to be sent to GA4 without any custom attributes from the inbound mParticle event (e.g. page_url, page_path, mpID, SessionID, or any other event-level attributes set by the customer).
Testing Plan
Master Issue
Closes https://go.mparticle.com/work/SDKE-781